View Issue Details

IDProjectCategoryView StatusLast Update
0002008T99X171.00 SKB EagleSWpublic2025-07-04 16:59
Reporter(ALTech) Sangmin Choi Assigned To(SW) Willin Deng Due Date2024-11-08 13:00
PrioritynormalSeveritys4-minorReproducibilityN/A
Status closedResolutionreopened 
Summary0002008: Please provide the hid-skbrm.ko which is modified some keycode value.
DescriptionSKB wants to increase the KEY_MAX value from 0x2ff to 0x3ff.
So, I'm going to test about 0x3ff KEY_MAX has problem or not.

And, I also want to check the value above 0x2ff works correctly or not.

I can modify key layout and kernel dts file, but I can't modify the hid-skbrm.ko.

Could you please build the hid-skbrm.ko after modify below keycode ?
key 469 SKB_FUNC_60 -> key 1015 SKB_FUNC_60

The source base is Eagle OS12 and branches are BFX-AT100_5.4.3.

Thank you.
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (ALTech) Jong-Hwa JUNG , (ALTech) JunGyu Kim , (ALTech) Wooshin Kang , (ALTech) Younkwang Jung , (Sales) Miya Wang , (SW) Kerwin Chen

Activities

(ALTech) Sangmin Choi

2024-11-06 15:11

developer   ~0016940

Hello, Kinbay,

Could you please check this ticket?

Thank you.
Sangmin Choi.

(SW) Kinbay Wu

2024-11-06 16:14

developer   ~0016941

Hi Sangmin

I have attached the hid-skbrm.ko as requested.
Please check it.

BR,
Kinbay
hid-skbrm.ko (439,544 bytes)

(ALTech) Sangmin Choi

2024-11-07 11:07

developer   ~0016942

Hello, Kinbay,

BFX-AT100_5.4.3 is hard to debug, because there is production patch so I can't use AML burning tool.

Could you please make hid-skbrm.ko again?
Eagle OS12 / BFX-AT100_5.4.2_Sprint2
key 468 SKB_FUNC_59 -> key 1015 SKB_FUNC_59

Thank you.
Sangmin Choi.

(SW) Kinbay Wu

2024-11-07 11:31

developer   ~0016943

Hi Sangmin

The two branches use the same file.
Please directly use the file on BFX-AT100_5.4.2_Sprint2

BR,
Kinbay

(ALTech) Sangmin Choi

2024-11-14 08:28

developer   ~0017004

Hello, Kinbay,

I'm preparing the firmware which KEY_MAX is increased.
But, when I press the front button, the STB hang up.
I guess the driver of front button refer the linux input driver.

vendor/foxconn/prebuilts/module/gpio_keypad.ko is related with Front Button(CH UP/DOWN) ?

If yes, please rebuild the gpio_keypad.ko at the below environment and apply patches.

branches : BFX-AT100_5.4.3
bionic.patch and common.patch

Thank you.
Sangmin Choi.
bionic.patch (486 bytes)   
git diff
diff --git a/libc/kernel/uapi/linux/input-event-codes.h b/libc/kernel/uapi/linux/input-event-codes.h
index 732e9b7bc..4bb8c40b4 100644
--- a/libc/kernel/uapi/linux/input-event-codes.h
+++ b/libc/kernel/uapi/linux/input-event-codes.h
@@ -660,7 +660,7 @@
 #define BTN_TRIGGER_HAPPY39 0x2e6
 #define BTN_TRIGGER_HAPPY40 0x2e7
 #define KEY_MIN_INTERESTING KEY_MUTE
-#define KEY_MAX 0x2ff
+#define KEY_MAX 0x3ff
 #define KEY_CNT (KEY_MAX + 1)
 #define REL_X 0x00
 #define REL_Y 0x01
bionic.patch (486 bytes)   
common.patch (1,151 bytes)   
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index df841a72b804..7403bf8d0d3d 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -284,7 +284,7 @@ struct pcmcia_device_id {
 /* Input */
 #define INPUT_DEVICE_ID_EV_MAX         0x1f
 #define INPUT_DEVICE_ID_KEY_MIN_INTERESTING    0x71
-#define INPUT_DEVICE_ID_KEY_MAX                0x2ff
+#define INPUT_DEVICE_ID_KEY_MAX                0x3ff
 #define INPUT_DEVICE_ID_REL_MAX                0x0f
 #define INPUT_DEVICE_ID_ABS_MAX                0x3f
 #define INPUT_DEVICE_ID_MSC_MAX                0x07
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
old mode 100644
new mode 100755
index b584868e1b26..b082ff735e83
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -686,7 +686,7 @@

 /* We avoid low common keys in module aliases so they don't get huge. */
 #define KEY_MIN_INTERESTING    KEY_MUTE
-#define KEY_MAX                        0x2ff
+#define KEY_MAX                        0x3ff
 #define KEY_CNT                        (KEY_MAX+1)

 /*
common.patch (1,151 bytes)   

(SW) Kinbay Wu

2024-11-14 15:07

developer   ~0017020

Hi Sangmin

Attached the gpio_keypad.ko.
Pleace check it.

BR,
Kinbay
gpio_keypad_20241114.ko (277,656 bytes)

(ALTech) Sangmin Choi

2024-11-14 18:46

developer   ~0017021

Hello, Kinbay,

It works correctly.

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-11-15 10:05

developer   ~0017023

Hello, Kinbay,

Attached patch is the modification I tested.

I changed the linux scancode of SA02 YouTube from 469 to 1015.
Because I want to check the increased KEY_MAX value has problem or not.

I can check the changed scancode is encountered correctly in case of IR mode.
But, the scancode 469 is still encountered in case of BT mode.

The question is,
to modify the scancode of RCU in case of BT mode, any prebuilts module needs to be modify?

Thank you.
Sangmin Choi.
BPM-38104.patch (5,170 bytes)   
repo diff

project bionic/
diff --git a/libc/kernel/uapi/linux/input-event-codes.h b/libc/kernel/uapi/linux/input-event-codes.h
index 732e9b7bc..4bb8c40b4 100644
--- a/libc/kernel/uapi/linux/input-event-codes.h
+++ b/libc/kernel/uapi/linux/input-event-codes.h
@@ -660,7 +660,7 @@
 #define BTN_TRIGGER_HAPPY39 0x2e6
 #define BTN_TRIGGER_HAPPY40 0x2e7
 #define KEY_MIN_INTERESTING KEY_MUTE
-#define KEY_MAX 0x2ff
+#define KEY_MAX 0x3ff
 #define KEY_CNT (KEY_MAX + 1)
 #define REL_X 0x00
 #define REL_Y 0x01

project common/
diff --git a/arch/arm64/boot/dts/amlogic/g12a_s905x2_eagle_3g.dts b/arch/arm64/boot/dts/amlogic/g12a_s905x2_eagle_3g.dts
old mode 100644
new mode 100755
index 91dc68e4ea8a..c05ac2fbe03a
--- a/arch/arm64/boot/dts/amlogic/g12a_s905x2_eagle_3g.dts
+++ b/arch/arm64/boot/dts/amlogic/g12a_s905x2_eagle_3g.dts
@@ -1755,7 +1755,7 @@
                         REMOTE_KEY(0x6A,466)        /*SA02 OTT Shortcut 1*/
                         REMOTE_KEY(0x6B,467)        /*SA02 OTT Shortcut 2*/
                         REMOTE_KEY(0x75,468)        /*SA02 OTT Shortcut 3*/
-                        REMOTE_KEY(0x6C,469)        /*SA02 YouTube*/
+                        REMOTE_KEY(0x6C,1015)        /*SA02 YouTube*/
 // VaS, start add integrated power key of SKB RCU by Logan@20190412
 // Vendor : 0xF1(yuwon), Version : 0x0 ~ 0xA, Total : 11
                         REMOTE_KEY(0x00F1,528)
@@ -2129,7 +2129,7 @@
                         REMOTE_KEY(0x6A,466)        /*SA02 OTT Shortcut 1*/
                         REMOTE_KEY(0x6B,467)        /*SA02 OTT Shortcut 2*/
                         REMOTE_KEY(0x75,468)        /*SA02 OTT Shortcut 3*/
-                        REMOTE_KEY(0x6C,469)        /*SA02 YouTube*/
+                        REMOTE_KEY(0x6C,1015)        /*SA02 YouTube*/
 // VaS, start add integrated power key of SKB RCU by Logan@20190412
 // Vendor : 0xF1(yuwon), Version : 0x0 ~ 0xA, Total : 11
                         REMOTE_KEY(0x00F1,528)
diff --git a/arch/arm64/configs/meson64_defconfig b/arch/arm64/configs/meson64_defconfig
index cb77e543ee8f..e21a8f3f48f8 100644
--- a/arch/arm64/configs/meson64_defconfig
+++ b/arch/arm64/configs/meson64_defconfig
@@ -656,7 +656,6 @@ CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_INFO=y
-CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_LOCKUP_DETECTOR=y
 # CONFIG_DETECT_HUNG_TASK is not set
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index df841a72b804..7403bf8d0d3d 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -284,7 +284,7 @@ struct pcmcia_device_id {
 /* Input */
 #define INPUT_DEVICE_ID_EV_MAX         0x1f
 #define INPUT_DEVICE_ID_KEY_MIN_INTERESTING    0x71
-#define INPUT_DEVICE_ID_KEY_MAX                0x2ff
+#define INPUT_DEVICE_ID_KEY_MAX                0x3ff
 #define INPUT_DEVICE_ID_REL_MAX                0x0f
 #define INPUT_DEVICE_ID_ABS_MAX                0x3f
 #define INPUT_DEVICE_ID_MSC_MAX                0x07
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index b584868e1b26..b082ff735e83 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -686,7 +686,7 @@

 /* We avoid low common keys in module aliases so they don't get huge. */
 #define KEY_MIN_INTERESTING    KEY_MUTE
-#define KEY_MAX                        0x2ff
+#define KEY_MAX                        0x3ff
 #define KEY_CNT                        (KEY_MAX+1)

 /*

project vendor/foxconn/
diff --git a/keyboards/Aml_keypad.kl b/keyboards/Aml_keypad.kl
old mode 100644
new mode 100755
index ae217b4..d6ff332
--- a/keyboards/Aml_keypad.kl
+++ b/keyboards/Aml_keypad.kl
@@ -179,7 +179,7 @@ key 465  SKB_FUNC_56        # SA02 OTT
 key 466  SKB_FUNC_57        # SA02 OTT Shortcut 1
 key 467  SKB_FUNC_58        # SA02 OTT Shortcut 2
 key 468  SKB_FUNC_59        # SA02 OTT Shortcut 3
-key 469  SKB_FUNC_60        # SA02 YouTube
+key 1015  SKB_FUNC_60        # SA02 YouTube

 # Gamepad buttons
 #key 256   SKB_FUNC_20
diff --git a/keyboards/Vendor_005d_Product_0007.kl b/keyboards/Vendor_005d_Product_0007.kl
index f46977c..769f30c 100755
--- a/keyboards/Vendor_005d_Product_0007.kl
+++ b/keyboards/Vendor_005d_Product_0007.kl
@@ -176,7 +176,7 @@ key 465   SKB_FUNC_56       # SA02 OTT
 key 466   SKB_FUNC_57       # SA02 OTT Shortcut 1
 key 467   SKB_FUNC_58       # SA02 OTT Shortcut 2
 key 468   SKB_FUNC_59       # SA02 OTT Shortcut 3
-key 469   SKB_FUNC_60       # SA02 YouTube
+key 1015   SKB_FUNC_60       # SA02 YouTube


 # Gamepad buttons
diff --git a/prebuilts/module/gpio_keypad.ko b/prebuilts/module/gpio_keypad.ko
index 3078af0..38aea7e 100644
Binary files a/prebuilts/module/gpio_keypad.ko and b/prebuilts/module/gpio_keypad.ko differ
diff --git a/prebuilts/module/remote.ko b/prebuilts/module/remote.ko
index 462bb5c..2b11cb7 100644
Binary files a/prebuilts/module/remote.ko and b/prebuilts/module/remote.ko differ

project vendor/skb/prebuilts/boot_config/
diff --git a/version.txt b/version.txt
index 9553f60a..5f670b71 100644
--- a/version.txt
+++ b/version.txt
@@ -1 +1 @@
-15.543.17
+15.543.1702
BPM-38104.patch (5,170 bytes)   

(ALTech) Sangmin Choi

2024-11-27 13:57

developer   ~0017095

Hello, Kinbay,

Could you please check my last comment?

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-12-20 09:45

developer   ~0017192

Hello, Kinbay,

Could you please check this comment?
https://btracker-cns.fii-foxconn.com/vaas/view.php?id=2008#c17023

Thank you.
Sangmin Choi.

Issue History

Date Modified Username Field Change
2024-11-06 15:10 (ALTech) Sangmin Choi New Issue
2024-11-06 15:10 (ALTech) Sangmin Choi Status new => assigned
2024-11-06 15:10 (ALTech) Sangmin Choi Assigned To => (SW) Kinbay Wu
2024-11-06 15:10 (ALTech) Sangmin Choi Issue Monitored: (SW) Kerwin Chen
2024-11-06 15:11 (ALTech) Sangmin Choi Issue Monitored: (Sales) Miya Wang
2024-11-06 15:11 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Wooshin Kang
2024-11-06 15:11 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Younkwang Jung
2024-11-06 15:11 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Jong-Hwa JUNG
2024-11-06 15:11 (ALTech) Sangmin Choi Issue Monitored: (ALTech) JunGyu Kim
2024-11-06 15:11 (ALTech) Sangmin Choi Note Added: 0016940
2024-11-06 16:14 (SW) Kinbay Wu Note Added: 0016941
2024-11-06 16:14 (SW) Kinbay Wu File Added: hid-skbrm.ko
2024-11-07 11:07 (ALTech) Sangmin Choi Note Added: 0016942
2024-11-07 11:31 (SW) Kinbay Wu Note Added: 0016943
2024-11-14 08:28 (ALTech) Sangmin Choi Note Added: 0017004
2024-11-14 08:28 (ALTech) Sangmin Choi File Added: bionic.patch
2024-11-14 08:28 (ALTech) Sangmin Choi File Added: common.patch
2024-11-14 15:07 (SW) Kinbay Wu Note Added: 0017020
2024-11-14 15:07 (SW) Kinbay Wu File Added: gpio_keypad_20241114.ko
2024-11-14 18:46 (ALTech) Sangmin Choi Note Added: 0017021
2024-11-14 18:46 (ALTech) Sangmin Choi Assigned To (SW) Kinbay Wu => (ALTech) Sangmin Choi
2024-11-14 18:46 (ALTech) Sangmin Choi Status assigned => closed
2024-11-14 18:46 (ALTech) Sangmin Choi Resolution open => fixed
2024-11-15 10:01 (ALTech) Sangmin Choi Assigned To (ALTech) Sangmin Choi => (SW) Kinbay Wu
2024-11-15 10:01 (ALTech) Sangmin Choi Status closed => feedback
2024-11-15 10:01 (ALTech) Sangmin Choi Resolution fixed => reopened
2024-11-15 10:05 (ALTech) Sangmin Choi Note Added: 0017023
2024-11-15 10:05 (ALTech) Sangmin Choi File Added: BPM-38104.patch
2024-11-15 10:05 (ALTech) Sangmin Choi Status feedback => assigned
2024-11-27 13:57 (ALTech) Sangmin Choi Note Added: 0017095
2024-12-20 09:45 (ALTech) Sangmin Choi Note Added: 0017192
2025-04-07 10:17 (SW) Kerwin Chen Assigned To (SW) Kinbay Wu => (SW) Willin Deng
2025-07-04 16:59 (PM) Sheila Tu Status assigned => closed